Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Remove mstdump from Mellanox's collect dump script #1706

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

DavidZagury
Copy link
Contributor

@DavidZagury DavidZagury commented Jul 5, 2021

What I did

Remove redundant mellanox dumps now that Mellanox SAI is taking care of that.

How I did it

Deleted the part related to mstdumps from the generate_script

How to verify it

Run 'show techsupport' see we no have mstdump folder but the actual dump available under the saisdk dump

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@BasimShalata
Copy link
Contributor

@liat-grozovik
FYI

@liat-grozovik liat-grozovik merged commit 888701b into sonic-net:master Jul 6, 2021
liat-grozovik pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Jul 7, 2021
Updates:
888701b [Mellanox] Remove mstdump from Mellanoxs collect dump script ([sonic-net/sonic-utilities#1706])
4818360 [sonic-package-manager] support warm/fast reboot for extension packages ([sonic-net/sonic-utilities#1554])
793b847 [show priority-group drop counters] Remove backup with cached PG drop counters after 'config reload' ([sonic-net/sonic-utilities#1679])
24fe1ac [show][config] support for interface alias for muxcable commands ([sonic-net/sonic-utilities#1699])
xumia pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Jul 9, 2021
Updates:
888701b [Mellanox] Remove mstdump from Mellanoxs collect dump script ([sonic-net/sonic-utilities#1706])
4818360 [sonic-package-manager] support warm/fast reboot for extension packages ([sonic-net/sonic-utilities#1554])
793b847 [show priority-group drop counters] Remove backup with cached PG drop counters after 'config reload' ([sonic-net/sonic-utilities#1679])
24fe1ac [show][config] support for interface alias for muxcable commands ([sonic-net/sonic-utilities#1699])
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
Updates:
888701b [Mellanox] Remove mstdump from Mellanoxs collect dump script ([sonic-net/sonic-utilities#1706])
4818360 [sonic-package-manager] support warm/fast reboot for extension packages ([sonic-net/sonic-utilities#1554])
793b847 [show priority-group drop counters] Remove backup with cached PG drop counters after 'config reload' ([sonic-net/sonic-utilities#1679])
24fe1ac [show][config] support for interface alias for muxcable commands ([sonic-net/sonic-utilities#1699])
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-utilities that referenced this pull request Aug 10, 2021
…et#1706)

- What I did
Remove redundant mellanox dumps now that Mellanox SAI is taking care of that.

- How I did it
Deleted the part related to mstdumps from the generate_script

- How to verify it
Run 'show techsupport' see we no have mstdump folder but the actual dump available under the saisdk dump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants